Added: Fuzzy Search/File Map for Detecting File Updates #2479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I thought we were just going with whatever file was newer, until we got the rest of the UI done for this. |
Al12rs
approved these changes
Jan 20, 2025
There was a problem hiding this comment.
A lot of this code will have to be thrown out when we get to actually writing an accurate update check, and tests will need to be updated accordingly.
That is unfortunate, but I don't think there is a point in delaying the PR to removing it now or something as opposed to later on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very small PR; just the stuff I added yesterday morning & afternoon.
This implements a 'fuzzy search' strategy for mapping that aren't the
file_updatesfield in the V1 API; and updates all of the related documentation around updates,This should be sufficient to make it work on 40-70% of mod pages (random guess), in the absence of proper links.
There are still some improvements that can be made, but for now I've decided to keep it relatively simple; i.e. covering most possible cases in minimum amount of work. Just enough to make it work on hopefully over half the mods; for a working prototype.